fix(audit): register OTel stats handler when audit is enabled without tracing - #6280
Open
erka wants to merge 1 commit into
Open
fix(audit): register OTel stats handler when audit is enabled without tracing#6280erka wants to merge 1 commit into
erka wants to merge 1 commit into
Conversation
… tracing The otelgrpc stats handler was only registered when tracing was enabled, but audit logging also depends on it for creating spans that carry audit events to the SinkSpanExporter. Without it, audit events added via span.AddEvent were silently dropped. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
dosubot
Bot
added
the
size:M
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6280 +/- ##
==========================================
+ Coverage 65.34% 66.92% +1.58%
==========================================
Files 169 169
Lines 14186 14191 +5
==========================================
+ Hits 9270 9498 +228
+ Misses 4240 3971 -269
- Partials 676 722 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The otelgrpc stats handler was only registered when tracing was enabled,
but audit logging also depends on it for creating spans that carry
audit events to the SinkSpanExporter. Without it, audit events added
via span.AddEvent were silently dropped.
closes #6279